-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Reset room key #6030
Merged
Merged
feat: Reset room key #6030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riginal value in case of a cancel on confirmation alert
diegolmello
commented
Dec 5, 2024
if (Array.isArray(value)) { | ||
value.forEach(val => { | ||
- params.push(`${encodeURIComponent(key)}=${encodeURIComponent(val)}`); | ||
+ params.push(`${encodeURIComponent(key)}[]=${encodeURIComponent(val)}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add to the SDK after merge
OtavioStasiak
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, great job!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Allows authorized users to reset the encryption key of E2EE rooms.
The idea is to prevent situations where all users of a room have lost the keys, and with that, have lost the access to use the room. Now Rocket.Chat will allow them to define a new set of keys for the room via UI.
If a user happens to have a key to the room, after the reset this will be moved to a list of oldRoomKeys, which the UI will use to decode older messages.
Issue(s)
Implements RocketChat/Rocket.Chat#33328
How to test or reproduce
key
icon on header or Room Actions > E2EE > ResetScreenshots
Types of changes
Checklist
Further comments
CORE-802